Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wait_for functionality for serial and parallel execution #97

Merged
merged 6 commits into from
Jul 25, 2023

Conversation

Harshith-umesh
Copy link
Member

Changes introduced with this PR

This PR adds the wait_for condition, which enables a workflow step to wait for another step without having a direct dependency between the two.

Use the latest release of the python deployer

Adds test cases for serial and parallel execution in a workflow.

Moves the printversion logic to the top of the main.go file immediately after parsing all the flags.
closes #52

Note:
This is only one of the parts required to enable parallel execution #63 , the ability to terminate parallel steps is still being developed.


By contributing to this repository, I agree to the contribution guidelines.

Copy link
Member

@dustinblack dustinblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the linting errors and the conversation w/ Jared about reducing the test time, this looks good to me.

@dustinblack
Copy link
Member

I was successful in functionally testing this with a workflow. Great work!

@Harshith-umesh
Copy link
Member Author

Race condition issue: #101

Copy link
Contributor

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a tiny typo, but let's get this merged.

@jaredoconnell jaredoconnell merged commit 7709776 into arcalot:main Jul 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to run workflow plugins serially without direct input/output data relationships
3 participants